Bad code examples

hhyyrylainen · January 11, 2020, 6:23pm

Another game that had its source code released (vvvvvvv) has really bad code:

TerryCavanagh/VVVVVV/blob/master/desktop_version/src/Game.cpp#L622


void Game::updatestate( Graphics& dwgfx, mapclass& map, entityclass& obj, UtilityClass& help, musicclass& music )
{
    int i;
    statedelay--;
    if(statedelay<=0){
		  statedelay=0;
			glitchrunkludge=false;
		}
    if (statedelay <= 0)
    {
        switch(state)
        {
        case 0:
            //Do nothing here! Standard game state
            break;
        case 1:
            //Game initilisation
            state = 0;
            break;
        case 2:
            //Opening cutscene

Don’t do that
(also see that nice new discourse github embed)