Error Saving - Saving failed!

idhrendur · January 10, 2021, 8:25am

After clicking evolve button. Did not cause an immediate crash.

Pastebin to the exception: Error Saving - Saving failed! An exception happened exception: System.Reflection - Pastebin.com

idhrendur · January 10, 2021, 8:27am

Error repeated on exiting editor.

hhyyrylainen · January 10, 2021, 8:28am

This is this issue:

MikroPik · January 19, 2021, 9:31am

I think I had a similar encounter but for me error happened only when entering editor

hhyyrylainen · January 19, 2021, 10:03am

That is the same error:

System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'PlacedOrganelle'.

Or rather the sister issue:

MikroPik · January 19, 2021, 11:20am

I allowed myself to create a long log filled to the brim with save errors.
I think error is more likely to happen if you click evolve button while or just apter absorbing organelle or chunk

hhyyrylainen · January 19, 2021, 12:14pm

Testing for saving errors with 0.5.3 is not really useful, as I’m pretty sure I have found the root cause (the microbe AI kept references to disposed objects) and fixed it. The fix is already included in devbuilds, and will be in the next official release as well.

Scyobi_Empire · January 20, 2021, 10:59am

I just got a save error, no crash

Edit: after thriving and finishing the game I got a copy of the exit logs, not sure if they’re any help.

MGS · May 4, 2021, 7:31pm

Got the error after clicking to reproduce, no crashes.

hhyyrylainen · May 5, 2021, 11:19am

Looks like a duplicate report of:

github.com/Revolutionary-Games/Thrive

New save error on disposed PlacedOrganelle at Node.GetGroups

opened 10:14AM - 15 Mar 21 UTC

hhyyrylainen

C# bug difficult programming saving

Slightly different from the old error when saving (caused by the AI): https://gi…thub.com/Revolutionary-Games/Thrive/issues/2014 The error: ``` Error Saving - Saving failed! An exception happened exception: System.ObjectDisposedException: Cannot access a disposed object. Object name: 'PlacedOrganelle'. at Godot.Object.GetPtr (Godot.Object instance) [0x0001c] in <b6bf450c2ab44fafb6278bd19225df9c>:0 at Godot.Node.GetGroups () [0x00000] in <b6bf450c2ab44fafb6278bd19225df9c>:0 at NodeGroupSaveHelper.WriteGroups (Newtonsoft.Json.JsonWriter writer, Godot.Node value, Newtonsoft.Json.JsonSerializer serializer) [0x0000b] in <7ec708c7874641c1b251467d569721c1>:0 at BaseNodeConverter.WriteCustomExtraFields (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.JsonSerializer serializer) [0x00000] in <7ec708c7874641c1b251467d569721c1>:0 at BaseThriveConverter.WriteJson (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.JsonSerializer serializer) [0x00248] in <7ec708c7874641c1b251467d569721c1>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeConvertable (Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonConverter converter, System.Object value, Newtonsoft.Json.Serialization.JsonContract contract, Newtonsoft.Json.Serialization.JsonContainerContract collectionContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x0008a] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeValue (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonContract valueContract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x00071] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeList (Newtonsoft.Json.JsonWriter writer, System.Collections.IEnumerable values, Newtonsoft.Json.Serialization.JsonArrayContract contract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract collectionContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x000d6] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeValue (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonContract valueContract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x000d6] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type objectType) [0x00079] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerProxy.SerializeInternal (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type rootType) [0x00008] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.JsonSerializer.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value) [0x00000] in <2676a2da6edc420e890ed28aa4572ee5>:0 at BaseThriveConverter.WriteMember (System.String name, System.Object memberValue, System.Type memberType, System.Type objectType, Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonSerializer serializer) [0x00012] in <7ec708c7874641c1b251467d569721c1>:0 at BaseThriveConverter.WriteJson (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.JsonSerializer serializer) [0x00192] in <7ec708c7874641c1b251467d569721c1>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeConvertable (Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonConverter converter, System.Object value, Newtonsoft.Json.Serialization.JsonContract contract, Newtonsoft.Json.Serialization.JsonContainerContract collectionContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x0008a] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeValue (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonContract valueContract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x00071] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type objectType) [0x00079] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerProxy.SerializeInternal (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type rootType) [0x00008] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.JsonSerializer.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value) [0x00000] in <2676a2da6edc420e890ed28aa4572ee5>:0 at BaseThriveConverter.WriteMember (System.String name, System.Object memberValue, System.Type memberType, System.Type objectType, Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonSerializer serializer) [0x00012] in <7ec708c7874641c1b251467d569721c1>:0 at BaseThriveConverter.WriteJson (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.JsonSerializer serializer) [0x00192] in <7ec708c7874641c1b251467d569721c1>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeConvertable (Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonConverter converter, System.Object value, Newtonsoft.Json.Serialization.JsonContract contract, Newtonsoft.Json.Serialization.JsonContainerContract collectionContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x0008a] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeValue (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonContract valueContract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x00071] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type objectType) [0x00079] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerProxy.SerializeInternal (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type rootType) [0x00008] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.JsonSerializer.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value) [0x00000] in <2676a2da6edc420e890ed28aa4572ee5>:0 at BaseThriveConverter.WriteMember (System.String name, System.Object memberValue, System.Type memberType, System.Type objectType, Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonSerializer serializer) [0x00012] in <7ec708c7874641c1b251467d569721c1>:0 at BaseThriveConverter.WriteJson (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.JsonSerializer serializer) [0x00229] in <7ec708c7874641c1b251467d569721c1>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeConvertable (Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonConverter converter, System.Object value, Newtonsoft.Json.Serialization.JsonContract contract, Newtonsoft.Json.Serialization.JsonContainerContract collectionContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x0008a] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeValue (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonContract valueContract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x00071] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeList (Newtonsoft.Json.JsonWriter writer, System.Collections.IEnumerable values, Newtonsoft.Json.Serialization.JsonArrayContract contract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract collectionContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x000d6] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeValue (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonContract valueContract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x000d6] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type objectType) [0x00079] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerProxy.SerializeInternal (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type rootType) [0x00008] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.JsonSerializer.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value) [0x00000] in <2676a2da6edc420e890ed28aa4572ee5>:0 at BaseThriveConverter.WriteMember (System.String name, System.Object memberValue, System.Type memberType, System.Type objectType, Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonSerializer serializer) [0x00012] in <7ec708c7874641c1b251467d569721c1>:0 at BaseThriveConverter.WriteJson (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.JsonSerializer serializer) [0x00229] in <7ec708c7874641c1b251467d569721c1>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeConvertable (Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonConverter converter, System.Object value, Newtonsoft.Json.Serialization.JsonContract contract, Newtonsoft.Json.Serialization.JsonContainerContract collectionContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x0008a] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeValue (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonContract valueContract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x00071] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type objectType) [0x00079] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerProxy.SerializeInternal (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type rootType) [0x00008] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.JsonSerializer.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value) [0x00000] in <2676a2da6edc420e890ed28aa4572ee5>:0 at BaseThriveConverter.WriteMember (System.String name, System.Object memberValue, System.Type memberType, System.Type objectType, Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonSerializer serializer) [0x00012] in <7ec708c7874641c1b251467d569721c1>:0 at BaseThriveConverter.WriteJson (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.JsonSerializer serializer) [0x00229] in <7ec708c7874641c1b251467d569721c1>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeConvertable (Newtonsoft.Json.JsonWriter writer, Newtonsoft.Json.JsonConverter converter, System.Object value, Newtonsoft.Json.Serialization.JsonContract contract, Newtonsoft.Json.Serialization.JsonContainerContract collectionContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x0008a] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeValue (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonContract valueContract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x00071] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeObject (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonObjectContract contract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract collectionContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x0008d] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.SerializeValue (Newtonsoft.Json.JsonWriter writer, System.Object value, Newtonsoft.Json.Serialization.JsonContract valueContract, Newtonsoft.Json.Serialization.JsonProperty member, Newtonsoft.Json.Serialization.JsonContainerContract containerContract, Newtonsoft.Json.Serialization.JsonProperty containerProperty) [0x000b2] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.Serialization.JsonSerializerInternalWriter.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type objectType) [0x00079] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.JsonSerializer.SerializeInternal (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type objectType) [0x0023a] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.JsonSerializer.Serialize (Newtonsoft.Json.JsonWriter jsonWriter, System.Object value, System.Type objectType) [0x00000] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.JsonConvert.SerializeObjectInternal (System.Object value, System.Type type, Newtonsoft.Json.JsonSerializer jsonSerializer) [0x00028] in <2676a2da6edc420e890ed28aa4572ee5>:0 at Newtonsoft.Json.JsonConvert.SerializeObject (System.Object value, System.Type type, Newtonsoft.Json.Formatting formatting, Newtonsoft.Json.JsonSerializerSettings settings) [0x0000e] in <2676a2da6edc420e890ed28aa4572ee5>:0 at ThriveJsonConverter+<>c__DisplayClass9_0.<SerializeObject>b__0 (Newtonsoft.Json.JsonSerializerSettings settings) [0x00000] in <7ec708c7874641c1b251467d569721c1>:0 at ThriveJsonConverter.PerformWithSettings[T] (System.Func`2[T,TResult] func) [0x0004b] in <7ec708c7874641c1b251467d569721c1>:0 at ThriveJsonConverter.SerializeObject (System.Object o, System.Type type) [0x00014] in <7ec708c7874641c1b251467d569721c1>:0 at Save.SaveToFile () [0x0002d] in <7ec708c7874641c1b251467d569721c1>:0 at SaveHelper.PerformSave (InProgressSave inProgress, Save save) [0x00000] in <7ec708c7874641c1b251467d569721c1>:0 ``` To track this down we need to first do this: https://github.com/Revolutionary-Games/Thrive/issues/2127 (I made a new issue as I didn't find an existing one)

Xauros · December 5, 2022, 2:58pm

I’m getting this error after playing for about two hours and when saving manually on Steam’s 0.5.10.0 version

hhyyrylainen · December 5, 2022, 3:00pm

Please provide the json_debug.txt file that should have been created in the Thrive logs folder (assuming default options). There’s a button in the options to open the logs folder.

Xauros · December 5, 2022, 3:16pm

I’m unable to find a logs folder under the steam’s install folder, AppData, Cache location or any other place, could you specify where it should be located?

hhyyrylainen · December 5, 2022, 3:16pm

It is in AppData somewhere. Use the button in the game options menu to open the logs folder. The JSON debug file is not overwritten if you restart the game (unless you set JSON debug mode to always in the options).

Xauros · December 5, 2022, 3:22pm

perfect, I was able to find it under \AppData\Roaming\Thrive\logs

contents are available here since the upload option doesn’t like .txt files:

hhyyrylainen · December 5, 2022, 3:31pm

Thanks. I was able to confirm your problem is a new variant of a bug that’s existed before. I’ve opened an issue for tracking fixing this issue:

github.com/Revolutionary-Games/Thrive

System.ObjectDisposedException save error at `MicrobeStage.Camera.ObjectToFollow.attemptingToEngulf[0].HostileEngulfer`

opened 03:30PM - 05 Dec 22 UTC

hhyyrylainen

difficult programming bug C# stage:microbe

Again a save error with the attempting to engulf stuff (apparently fixing https:…//github.com/Revolutionary-Games/Thrive/issues/3474 didn't fully fix it). Here's the relevant debug log: ``` 2022-12-05T08:59:37.053 Info Finished serializing CompoundBag with converter DefaultThriveJSONConverter. Path 'MicrobeStage.Camera.ObjectToFollow.attemptingToEngulf[0].Compounds'. 2022-12-05T08:59:37.053 Info Started serializing EntityReference`1[Microbe] with converter EntityReferenceConverter. Path 'MicrobeStage.Camera.ObjectToFollow.attemptingToEngulf[0].HostileEngulfer'. 2022-12-05T08:59:37.053 Info Writing object reference to Id '13390' for Microbe. Path 'MicrobeStage.Camera.ObjectToFollow.attemptingToEngulf[0].HostileEngulfer'. 2022-12-05T08:59:37.053 Info Finished serializing EntityReference`1[Microbe] with converter EntityReferenceConverter. Path 'MicrobeStage.Camera.ObjectToFollow.attemptingToEngulf[0].HostileEngulfer'. 2022-12-05T08:59:37.061 Error Error serializing System.Collections.Generic.HashSet`1[IEngulfable]. Cannot access a disposed object. Object name: 'FloatingChunk'. Path 'MicrobeStage.Camera.ObjectToFollow.attemptingToEngulf[0]'. 2022-12-05T08:59:37.061 Error Error serializing Microbe. Cannot access a disposed object. Object name: 'FloatingChunk'. Path 'MicrobeStage.Camera.ObjectToFollow.attemptingToEngulf[0].NodeGroups'. 2022-12-05T08:59:37.061 Error Error serializing MicrobeCamera. Cannot access a disposed object. Object name: 'FloatingChunk'. Path 'MicrobeStage.Camera.ObjectToFollow.attemptingToEngulf[0].NodeGroups'. 2022-12-05T08:59:37.061 Error Error serializing Save. Cannot access a disposed object. Object name: 'FloatingChunk'. Path 'MicrobeStage.Camera.ObjectToFollow.attemptingToEngulf[0]'. ``` Full log: https://pastebin.com/EYp7SCCZ

In the meantime, you can probably save if you use the suicide button to respawn and save immediately after respawning as the problem is some objects in bad state that your cell is wanting to engulf.