What should I do if I registered on CLA but forgot my account password and now I can’t log in?
2 Likes
Unless you are a patron, you do not have a ThriveDevCenter account (only us developers and Patreon supporters have an account).
3 Likes
How then to make sure that the PR is passed despite the absence of CLA?
2 Likes
You do not need an account to sign the CLA. The CLA page says that you should sign in if you have an account.
3 Likes
How can I make GitHub see that I signed the CLA?
2 Likes
Once you start signing the CLA there is a button to link your GitHub account with the CLA, so press that and log in with github. Then the CLA signing process saves your github account info into the CLA signature.
2 Likes
revolutionary-bot still thinks that I haven’t signed the CLA or linked it to github, even though I’ve already done that.
2 Likes
There needs to be an update on the PR to trigger the check again. I noticed last week(?) that updating the CLA status after a new signature is created doesn’t work for some reason. But I should have fixed an issue that prevented the pull request from updating totally.
Actually I just checked and the CLA status has updated on your PR:
1 Like
Should I just wait or change the PR to get it approved? It just says: “At least 1 approving review is required by reviewers with write access.”
2 Likes
Did you get comments on your PR already? If so you should address them by either code changes or by discussing why you don’t think changes are necessary. I only give approving reviews to game balance changes after they are extensively tested and the change is found to be good.
2 Likes
There was a comment saying the nerfs are too extreme, which isn’t a good sign for it’s future…
1 Like
I explained to them why photosynthesis is currently out of balance, even providing evidence in the form of screenshots, but there is still no answer.
2 Likes
Evaluation and testing of a PR takes time, even for seemingly simple balance changes as we want to make sure that the gameplay is as positively affected as it can be. It is usually only bug fixing changes that go through the review process quickly, as those don’t require much decision making to figure out how they affect the gameplay.
Changing photosynthesis is an especially important area of the game, so I would expect it to take even more time to evaluate. Also, while we have identified that current photosynthesis is out of balance, there are many different ways we might want to evaluate in order to balance photosynthesis.
What would be most helpful right now is likely just more testing, Have you played through with the changes on Easy, Medium, and Hard difficulty? What happens if you play through a couple of games on the warm pool setting, do photosynthesizers evolve like how you would expect them to? (Being more sedentary, but also prevalent)
5 Likes
A good photosynthesis nerf is an one which doesn’t make photosynthesis a hyperspecialist niche.
2 Likes
Yeah, it’s extremely fast to get 2 people to test your balance change PR within 24 hours. I expect that this kind of unpopular photosynthesis balance change would take at least a week + to be accepted. And we might require new tutorials or new features (different bioprocesses in hard mode) before considering merging this change.
Exactly, chloroplasts are way too weak compared to thylakoids currently, so a higher priority change is to buff chloroplasts.
And also one that ensures that new players aren’t completely overwhelmed / require knowledge they don’t have. The compound balance and storage time displays in the game don’t currently have any tutorials. So if we make photosynthesis harder we need multiple new tutorials related to photosynthesis.
3 Likes
Pretty sure tutorials are up for being upgraded soon already, so if we are going for THE FINAL photosynthesis rebalance, this can be the golden chance to do so.
Not either of the tutorials I mentioned are getting any attention whatsoever. So the hope for those being bundled into the ongoing tutorial changes, is just totally inaccurate.
1 Like
I think it’s better to replace those long texts that appear when your body can’t survive the night when powered by photosynthesis with “increase the storage of compounds to survive the night!” and “increase the production of glucose to survive the night!”.
I also think that the efficiency of photosynthesis in my patch should optimally be increased to 0.1 for chloroplasts and 0.08 for thylakoids.
1 Like
That seems to be quite the gap between thylakoids and chloroplasts being suggested here…
Also are you saying that photosynthesis efficiency (not sunlight values) should be patch-dependent?
by “patch” i meant fix, not biomes. Also deus told me that they are going to increase the efficiency of chloroplasts compared to thylakoids.
1 Like