What if I already have a created fork?
1 Like
Then use the existing fork, but youâll probably want to sync it with the latest Thrive master code. I think nowadays thereâs a button on the github website to do that so you donât even need to know the git commands to do that.
1 Like
My fork already has changes and a pull request, if I change it the pull request of my photosynthesys patch will also change.
1 Like
What do you plan to change within this fork including photosynthesis rebalance by the way?
In git you should always make a new branch when you start making changes. That way you can keep the master branch clean for making even more changes (even before the first changes have been merged).
1 Like
It could be but I donât expect that to compile as HasNucleus property is not available in that function like that.
And again any messing with the tolerances will make it show up in the GUI bonuses section.
I think Iâve said it way back that changes to either the ProcessSystem or how MicrobeEnvironmentalEffects.ProcessSpeedModifier is setup would be needed to do this properly without having extra effects showing up in unexpected places in the GUI.
2 Likes
At some point later on in the currently prototypal stages, will there be references/easter eggs to the old prototype features like the placeholder trees in the land aware/awakening stage prototype?
2 Likes
Iâm like 100% sure that does not compile either. I was referring to a field in a class with that name, which is a component on microbe entities, which should have no way of being in scope there. Instead the code would need to be put where that field is actually modified.
It is pretty much a waste of my time trying to tell you what code to write if you arenât even trying to compile your attempts to make sure they are valid code.
2 Likes
Also, what happened with âLetâs code Thrive togetherâ (or whatever was that called) RG YT series?
1 Like
Well nothing, really. I just havenât set out a time when I would do it again (as always there are complex big items on my TODO list that would not work for a stream), and no one else has either wanted to do such a stream.
2 Likes
Do you think these streams of coding could work (achieve their goals) better if there was a larger following to Thrive?
2 Likes
And why are you showing me that? Iâm again like 99% sure that that code cannot compile as HasNucleus is not a property of the system itself so you need actual code to read the properties of the cell the system is running on to determine if it is an eukaryote or not. But that code should theoretically work if that part was written correctly. However this would result in the gameplay osmoregulation and what is shown in the editor to get out of sync (so the editor would still show old osmoregulation numbers).
4 Likes
Where in the game files is the code that reads the properties of the cell that I could copy so that osmoregulation would read the presence of a nucleus?
2 Likes
Youâll have to clarify what you want. There is no single place that just reads if a microbe has a nucleus. Unless you literally just want the property update, but that isnât the place an osmoregulation bonus would logically be calculated in:
The OsmoregulationAndHealingSystem actually already reads CellProperties so it would be pretty easy to update the actual code that takes the osmoregulation cost to read the CellProperties.IsBacteria field, somewhere around here:
3 Likes
No, as far as I can tell by quickly looking that will not compile. I will stop responding now as it is 100% a waste of my time to try to suggest you something if you wonât even try to compile it or to understand the surrounding code yourself to make the small changes that are needed to fit the code to where you put it.
3 Likes
